Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor MockCCIPRouter to support EVMExtraArgsV2 #1532

Open
wants to merge 7 commits into
base: ccip-develop
Choose a base branch
from
Open

Refactor MockCCIPRouter to support EVMExtraArgsV2 #1532

wants to merge 7 commits into from
+38 −8

Conversation

andrejrakic
Copy link

Motivation

Because of this check in the MockRouter contract https://github.com/smartcontractkit/ccip/blob/ccip-develop/contracts/src/v0.8/ccip/test/mocks/MockRouter.sol#L126 the local testing is failing when EVMExtraArgsV2 is used.

Solution

Refactor MockCCIPRouter to support EVMExtraArgsV2.

0xsuryansh
0xsuryansh previously approved these changes Nov 18, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RensR RensR RensR approved these changes

@0xsuryansh 0xsuryansh 0xsuryansh left review comments

@makramkd makramkd Awaiting requested review from makramkd makramkd is a code owner

@elatoskinas elatoskinas Awaiting requested review from elatoskinas elatoskinas is a code owner

@RayXpub RayXpub Awaiting requested review from RayXpub RayXpub is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrejrakic @RensR @0xsuryansh